Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using @octokit/types #17

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Switch to using @octokit/types #17

merged 1 commit into from
Nov 3, 2019

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Nov 3, 2019

There are some minor incompatibilities causing issues with octokit/auth-app.js#27.

@frangio frangio mentioned this pull request Nov 3, 2019
Merged
gr2m
gr2m approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m merged commit 56e5aa3 into octokit:master Nov 3, 2019
@gr2m
Copy link
Contributor

gr2m commented Nov 3, 2019

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m added the released label Nov 3, 2019
@frangio frangio deleted the use-octokit-types branch November 3, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frangio @gr2m